logilab-astng #70565 absolute imports treated as relative [validation pending]

Comments

• 2011/07/08 08:37, written by Jajcus

  fixed patch formatting:

  diff -dur logilab-astng-0.21.1.orig/scoped_nodes.py logilab-astng-0.21.1/scoped_nodes.py
  --- logilab-astng-0.21.1.orig/scoped_nodes.py 2011-01-11 15:47:29.000000000 +0100
  +++ logilab-astng-0.21.1/scoped_nodes.py      2011-07-08 10:19:38.000000000 +0200
  @@ -342,6 +342,8 @@
           # XXX this returns non sens when called on an absolute import
           # like 'pylint.checkers.logilab.astng.utils'
           # XXX doesn't return absolute name if self.name isn't absolute name
  +        if self.absolute_import_activated() and level is None:
  +            return modname
           if level:
               if self.package:
                   level = level - 1
  
• 2011/07/08 09:16, written by Jajcus

  Ooops… the patch had a bad side effect ('relative_only' stopped working). Here is an updated one:

  --- logilab-astng-0.21.1.orig/scoped_nodes.py   2011-01-11 15:47:29.000000000 +0100
  +++ logilab-astng-0.21.1/scoped_nodes.py        2011-07-08 11:07:34.000000000 +0200
  @@ -324,6 +324,8 @@
  
       def import_module(self, modname, relative_only=False, level=None):
           """import the given module considering self as context"""
  +        if relative_only and level is None:
  +            level = 0
           absmodname = self.relative_to_absolute_name(modname, level)
           try:
               return MANAGER.astng_from_module_name(absmodname)
  @@ -342,6 +344,8 @@
           # XXX this returns non sens when called on an absolute import
           # like 'pylint.checkers.logilab.astng.utils'
           # XXX doesn't return absolute name if self.name isn't absolute name
  +        if self.absolute_import_activated() and level is None:
  +            return modname
           if level:
               if self.package:
                   level = level - 1
  
  • 2012/07/07 12:47, written by mostrows

    Please sse bug 99413. This patch is currently broken. This is apparently due to the fact that the default value for level from mixins.py:110 is 0 not None. node_classes.py:595 (the From.__init__ method) defaults "level" to 0.