pylint #70495 absolute imports fail depending on module path [validation pending]
[0] vostro:~/tmp$ pylint src/s3ql/argparse.py
[20] vostro:~/tmp$ (cd src; pylint s3ql/argparse.py)
[20] vostro:~/tmp$ cat src/s3ql/argparse.py
import argparse
[0] vostro:~/tmp$ cat src/s3ql/__init__.py
[0] vostro:~/tmp$ pylint --version
[0] vostro:~/tmp$ | |
| priority | normal |
|---|---|
| type | bug |
| done in | 0.24.0 |
| load | 0.200 |
| load left | 0.000 |
| closed by | #2a5477c2a57f closes #70495: absolute imports fail depending on module path (patch by Jacek Konieczny) |
ticket traceability chain
- #46772 absolute imports fail depending on module path - not validated
- #70495 absolute imports fail depending on module path - validation pending
Comments
-
2011/07/08 08:36, written by Jajcus
-
2011/07/08 09:23, written by Jajcus
add commentA simple patch to logilab-astng fixes that: http://www.logilab.org/ticket/70565
The 'variables' checker in Pylint relied on the broken behaviour, so, after patching logilab-astng, a patch to Pylint is also needed:
diff -dur pylint-0.23.0.orig/checkers/variables.py pylint-0.23.0/checkers/variables.py --- pylint-0.23.0.orig/checkers/variables.py 2011-01-11 15:55:06.000000000 +0100 +++ pylint-0.23.0/checkers/variables.py 2011-07-08 11:03:13.000000000 +0200 @@ -455,7 +455,8 @@ """check modules attribute accesses""" name_parts = node.modname.split('.') try: - module = node.root().import_module(name_parts[0]) + level = getattr(node, 'level', None) + module = node.root().import_module(name_parts[0], level = level) except ASTNGBuildingException: return except Exception, exc: