logilab-devtools #6146 'changelog close' seems confused about version numbers [resolved]
trace: auc@crater:~/rep/clients/estock/eStock$ cat version.txt 1.8.4 auc@crater:~/rep/clients/estock/eStock$ changelog close logilab.devtools.lgp.changelog Traceback (most recent call last): File "/home/auc/bin/changelog", line 5, in <module> changelog.run(sys.argv[1:]) File "/home/auc/rep/public/logilab/devtools/changelog.py", line 110, in run chlg.close(pkg_dir, create) File "/home/auc/rep/public/logilab/devtools/lgp/changelog.py", line 104, in close '%s >= %s !' % (self.entries[1].version, version) AssertionError: 1.8.3 >= 1.8.4 ! | |
| priority | normal |
|---|---|
| type | bug |
| done in | 0.13.2 |
| load left | 0.000 |
| closed by | <not specified> |
Comments
-
2009/01/16 18:39, written by acampeas
-
2009/01/19 13:30
add commentnot all packages are comparable using dpkg :
class Version(object): def __init__(self, versionstr): self.value = versionstr.strip() def __str__(self): return self.value def __compare(self, op, other): if isinstance(other, Version): status = subprocess.call(['dpkg', '--compare-versions', self.value, op, other.value]) return (status == 0) return NotImplemented def __eq__(self, other): return self.__compare('eq', other) def __ne__(self, other): return self.__compare('ne', other) def __lt__(self, other): return self.__compare('lt', other) def __le__(self, other): return self.__compare('le', other) def __gt__(self, other): return self.__compare('gt', other) def __ge__(self, other): return self.__compare('ge', other)The real issue is that version 1.8.3 is an instance of logilab.common.changelog.Version and version 1.8.4 is an instance of logilab.devtools.lgp.changelog.Version. The former has no value attribute and therefore the call to __lt__ fails with AttributeError, and Python defaults to the standard comparison (using object identities as a key).