pylint #5672 W0706 weirdness [resolved]

maarten reported...

When I run pylint on the following code:

class MultiException(Exception):

  def __init__(self):
      Exception.__init__(self)
      self.messages = []

  def add_error(self, message):
      self.messages.append(message)
      return self

raise MultiException().add_error('blah')

I get the following output:

W0706: 11: Identifier MultiException().add_error('blah') used to raise an
exception is assigned to class MultiException(Exception):
  def __init__(self):
      Exception.__init__(self)
      self.messages = []
  def add_error(self, message):
      self.messages.append(message)
      return self

I don't understand what this warning is warning me about. Also, I think it's very strange that the class body is included in the warning.

Versions used: pylint 0.14.0, astng 0.17.2, common 0.22.1 Python 2.5.1 (r251:54863, Mar 7 2008, 03:41:45)

prioritynormal
typebug
done in0.15.2
load0.000
load left0.000
closed by<not specified>

Workflow history

from state (2)to statecommentdateUser
validation pendingresolved2009/03/23 09:51 UTCsthenault
openvalidation pending

W0706 message has been removed

2008/10/13 13:04 UTCeanclin

Comments

  • 2008/07/30 13:07, written by sthenault

    The wording is a bit confusing, I would expect something like 'Expression "(1) + (1)" has type "int" but is raised as an exception'.

    It seems though that the inference correctly determined that MultiException.add_error() returns a MultiException object, since the warning was able to print the body of the MultiException class.

  • 2008/09/24 15:22, written by eanclin

    this happens also on this case

    class Foo(object):
    def return_self(self):
        return self

raise Foo().return_self()

    yielding

    W0706: 8: Identifier Foo().return_self() used to raise an exception is
assigned to class Foo:
    def return_self(self):
         return self

    but no warning for

    raise Foo

    (where there should be at least a warning since python raises TypeError )

add comment

Ticket #5672 - latest update on 2009/09/01, created on 2008/07/30 by Sylvain Thenault