logilab-astng #52785 check const_factory usage in scoped_nodes [open]
in the current implementation of the Class.getatrr method, there is no usage of the nodes passed to const_factory; we can even remove it without breaking any test: --- a/scoped_nodes.py Tue Dec 14 12:13:51 2010 +0100 +++ b/scoped_nodes.py Tue Dec 14 12:34:02 2010 +0100 @@ -856,11 +856,11 @@ if name == '__module__': return [cf(self.root().qname())] + values if name == '__bases__': - return [cf(tuple(self.ancestors(recurs=False, context=context)))] + values + return [cf(tuple())] + values # XXX need proper meta class handling + MRO implementation if name == '__mro__' and self.newstyle: # XXX mro is read-only but that's not our job to detect that - return [cf(tuple(self.ancestors(recurs=True, context=context)))] + values + return [cf(tuple())] + values return std_special_attributes(self, name) # don't modify the list in self.locals! values = list(values) | |
priority | normal |
---|---|
type | task |
done in | <not specified> |
closed by | <not specified> |