pylint #48066 pylint crashes when redirecting output containing non-ascii characters [resolved]

I'm forwarding http://bugs.debian.org/598482

$ cat test.py
#-*-coding:iso-8859-1-*-
class test:
   def __init__ (self,dir) :
       testString = u"répertoire :\n%s !"%dir

$ pylint -f parseable test.py > test.txt
No config file found, using default configuration
Traceback (most recent call last):
  File "/usr/bin/pylint", line 4, in 
    lint.Run(sys.argv[1:])
  File "/usr/lib/pymodules/python2.6/pylint/lint.py", line 856, in __init__
    linter.check(args)
  File "/usr/lib/pymodules/python2.6/pylint/lint.py", line 488, in check
    self.check_astng_module(astng, walker, rawcheckers)
  File "/usr/lib/pymodules/python2.6/pylint/lint.py", line 563, in
check_astng_module
    walker.walk(astng)
  File "/usr/lib/pymodules/python2.6/pylint/utils.py", line 516, in walk
    self.walk(child)
  File "/usr/lib/pymodules/python2.6/pylint/utils.py", line 516, in walk
    self.walk(child)
  File "/usr/lib/pymodules/python2.6/pylint/utils.py", line 516, in walk
    self.walk(child)
  File "/usr/lib/pymodules/python2.6/pylint/utils.py", line 513, in walk
    cb(astng)
  File "/usr/lib/pymodules/python2.6/pylint/checkers/format.py", line 317, in
visit_default
    self.add_message(msg_def[0], node=node, args=msg_def[1])
  File "/usr/lib/pymodules/python2.6/pylint/checkers/__init__.py", line 92, in
add_message
    self.linter.add_message(msg_id, line, node, args)
  File "/usr/lib/pymodules/python2.6/pylint/utils.py", line 274, in add_message
    self.reporter.add_message(msgid, (path, module, obj, line or 1), msg)
  File "/usr/lib/pymodules/python2.6/pylint/reporters/text.py", line 97, in
add_message
    self.writeln(self.line_format % locals())
  File "/usr/lib/pymodules/python2.6/pylint/reporters/__init__.py", line 55, in
writeln
    print >> self.out, string
UnicodeEncodeError: 'ascii' codec can't encode characters in position 86-87:
ordinal not in range(128)

when I remove encoding specification at the beginning of the file, the problem
vanishes but I get PyLint error relative to PEP263 (non ascii characters and no
encoding specification).
prioritynormal
typebug
done in0.21.4
load0.100
load left0.000
closed by<not specified>

Workflow history

from state (3)to statecommentdateUser
validation pendingresolved2011/03/10 10:10 UTCsthenault
donevalidation pending

version published

2010/10/27 13:20 UTC 
opendone2010/10/21 12:50 UTCeanclin

Comments

  • 2010/10/15 20:11, written by anon

    I wrote a patch to fix this bug:

    diff -ruN pylint.orig/reporters/__init__.py pylint/reporters/__init__.py --- pylint.orig/reporters/__init__.py 2010-10-16 00:56:28.000000000 +0600 +++ pylint/reporters/__init__.py 2010-10-16 01:02:50.000000000 +0600 @@ -16,7 +16,7 @@

    ReST / HTML errors:System Message: ERROR/3 (&lt;string&gt; , line 7)</p>
    Unexpected indentation.
    http://www.logilab.fr/ -- mailto:contact@logilab.fr
    ReST / HTML errors:System Message: WARNING/2 (&lt;string&gt; , line 8)</p>
    Block quote ends without a blank line; unexpected unindent.

    """

    -import sys +import sys, codecs, locale

    CMPS = ['=', '-', '+']
    @@ -42,17 +42,24 @@
    self.include_ids = None self.section = 0 self.out = None
    ReST / HTML errors:System Message: WARNING/2 (&lt;string&gt; , line 19)</p>
    Definition list ends without a blank line; unexpected unindent.
    • self.out_encoding = None self.set_output(output)
    def set_output(self, output=None):

    """set output stream""" if output is None:

    ReST / HTML errors:System Message: ERROR/3 (&lt;string&gt; , line 25)</p>
    Unexpected indentation.
    output = sys.stdout
    ReST / HTML errors:System Message: WARNING/2 (&lt;string&gt; , line 26)</p>
    Block quote ends without a blank line; unexpected unindent.
    • self.out_encoding = (output.encoding or
    • locale.getdefaultlocale()[1] or
    • sys.getdefaultencoding())
    • if output.encoding is None:
    • output = codecs.getwriter(self.out_encoding)(output)
    ReST / HTML errors:System Message: WARNING/2 (&lt;string&gt; , line 31)</p>
    Bullet list ends without a blank line; unexpected unindent.
    self.out = output
    def writeln(self, string=''):
    """write a line in the output buffer"""
    ReST / HTML errors:System Message: WARNING/2 (&lt;string&gt; , line 35)</p>
    Block quote ends without a blank line; unexpected unindent.
    • print >> self.out, string
    ReST / HTML errors:System Message: WARNING/2 (&lt;string&gt; , line 36)</p>
    Bullet list ends without a blank line; unexpected unindent.
    • print >> self.out, (string if isinstance(string, unicode) else
    • string.decode(self.out_encoding, 'replace'))
    def display_results(self, layout):
    """display results encapsulated in the layout tree"""
  • 2010/10/15 20:13, written by anon

    I wrote a patch to fix this bug:

    diff -ruN pylint.orig/reporters/__init__.py pylint/reporters/__init__.py
--- pylint.orig/reporters/__init__.py       2010-10-16 00:56:28.000000000 +0600
+++ pylint/reporters/__init__.py    2010-10-16 01:02:50.000000000 +0600
@@ -16,7 +16,7 @@
  http://www.logilab.fr/ -- mailto:contact@logilab.fr
 """

-import sys
+import sys, codecs, locale

 CMPS = ['=', '-', '+']

@@ -42,17 +42,24 @@
         self.include_ids = None
         self.section = 0
         self.out = None
+        self.out_encoding = None
         self.set_output(output)

     def set_output(self, output=None):
         """set output stream"""
         if output is None:
             output = sys.stdout
+        self.out_encoding = (output.encoding or
+                             locale.getdefaultlocale()[1] or
+                             sys.getdefaultencoding())
+        if output.encoding is None:
+            output = codecs.getwriter(self.out_encoding)(output)
         self.out = output

     def writeln(self, string=''):
         """write a line in the output buffer"""
-        print >> self.out, string
+        print >> self.out, (string if isinstance(string, unicode) else
+                            string.decode(self.out_encoding, 'replace'))

     def display_results(self, layout):
         """display results encapsulated in the layout tree"""
  • 2010/10/16 12:52, written by anon

    Here is another version or the unicode-output.patch:

    diff -ruN pylint.orig/reporters/__init__.py pylint/reporters/__init__.py
--- pylint.orig/reporters/__init__.py       2010-10-16 00:56:28.000000000 +0600
+++ pylint/reporters/__init__.py    2010-10-16 18:45:01.000000000 +0600
@@ -16,7 +16,7 @@
  http://www.logilab.fr/ -- mailto:contact@logilab.fr
 """

-import sys
+import sys, locale

 CMPS = ['=', '-', '+']

@@ -42,17 +42,20 @@
         self.include_ids = None
         self.section = 0
         self.out = None
+        self.out_encoding = None
         self.set_output(output)

     def set_output(self, output=None):
         """set output stream"""
-        if output is None:
-            output = sys.stdout
-        self.out = output
+        self.out = output or sys.stdout
+        self.out_encoding = (self.out.encoding or
+                             locale.getdefaultlocale()[1] or
+                             sys.getdefaultencoding())

     def writeln(self, string=''):
         """write a line in the output buffer"""
-        print >> self.out, string
+        print >> self.out, (isinstance(string, unicode) and
+                            string.encode(self.out_encoding) or string)

     def display_results(self, layout):
         """display results encapsulated in the layout tree"""
add comment