logilab-common #24450 optik_ext import breaks optparse [resolved]

after optik_ext is imported, some stuff is overridden in the optparse module and this breaks help generation of "normal" optparse scripts:

 File "/usr/lib/python2.5/optparse.py", line 1617, in format_option_help
   result.append(OptionContainer.format_option_help(self, formatter))
 File "/home/alf/cubicweb/logilab/common/optik_ext.py", line 277, in format_option_help
   if option.level <= outputlevel and not option.help is SUPPRESS_HELP:
AttributeError: Option instance has no attribute 'level'
priorityimportant
typebug
done in0.50.2
load0.200
load left0.000
closed by<not specified>

Workflow history

from state (3)to statecommentdateUser
validation pendingresolved2010/08/26 07:51 UTCsthenault
donevalidation pending

version published

2010/05/25 08:11 UTCsthenault
opendone2010/05/03 10:11 UTC 

Comments

  • 2010/05/18 02:19, written by anon

    Same issue with paver and logilab_common-0.50.1:

    $ paver help

Traceback (most recent call last):
  File "../workspace/.buildout/eggs/Paver-1.0.2-py2.6.egg/paver/tasks.py", line 170, in _run_task
    return do_task()
  File "../workspace/.buildout/eggs/Paver-1.0.2-py2.6.egg/paver/tasks.py", line 167, in do_task
    return func(**kw)
  File "../workspace/.buildout/eggs/Paver-1.0.2-py2.6.egg/paver/tasks.py", line 543, in help
    help_function()
  File "/usr/lib/python2.6/optparse.py", line 1664, in print_help
    file.write(self.format_help().encode(encoding, "replace"))
  File "/usr/lib/python2.6/optparse.py", line 1644, in format_help
    result.append(self.format_option_help(formatter))
  File "/usr/lib/python2.6/optparse.py", line 1624, in format_option_help
    result.append(OptionContainer.format_option_help(self, formatter))
  File "../workspace/.buildout/eggs/logilab_common-0.50.1-py2.6.egg/logilab/common/optik_ext.py", line 264, in format_option_help
    if option.level <= outputlevel and not option.help is SUPPRESS_HELP:
AttributeError: Option instance has no attribute 'level'
  • 2010/05/18 02:38, written by anon

    Basic NOP

    ... in ./eggs/logilab_common-0.50.1-py2.6.egg/logilab/common/optik_ext.py

    Changed line 264 from:

    if option.level <= outputlevel and not option.help is SUPPRESS_HELP:

    To:

    if getattr(option,'level',0) <= outputlevel) and not option.help is SUPPRESS_HELP:
  • 2010/05/18 02:42, written by anon

    Turns out afayolle already fixed this in http://www.logilab.org/cgi-bin/hgwebdir.cgi/logilab/common/rev/d706bd7eabcf .

    Any ETA on 0.50.2?

add comment