hgview #113034 hgview should not manipulated sys.path [validation pending]

priorityimportant
typebug
done in1.7.1
load0.250
load left0.000
closed by#32d191e8504d Remove sys.path manipulation (closes #113034)

Workflow history

from state (3)to statecommentdateUser
donevalidation pending2013/01/31 11:14 UTCnchauvat
in-progressdone2012/12/10 15:17 UTC 
openin-progress2012/12/07 14:17 UTC 

Comments

  • 2013/01/09 00:36, written by anon

    The current code now does not work out of the box as cloned repo anymore.

    To fix both issues, sys.path manipulations can be used only when the regular import fails (try-except).

  • 2013/01/16 11:51, written by anon

    After this change was introduced, the README instructions how to use it as a mercurial extension are not valid any more and results in:

    *** failed to import extension hgview from /home/wujek/mercurial/ext/hgview/hgext/hgview.py: No module named hgviewlib
    hg: unknown command 'qv'

    One has to set PYTHONPATH to include hgviewlib module oneself. I would consider it a step back actually, it used to work out of the box.

add comment

Ticket #113034 - latest update on 2013/01/31, created on 2012/12/04 by Pierre-Yves David