hgview #113034 hgview should not manipulated sys.path [validation pending]
priority | important |
---|---|
type | bug |
done in | 1.7.1 |
load | 0.250 |
load left | 0.000 |
closed by | #32d191e8504d Remove sys.path manipulation (closes #113034) |
priority | important |
---|---|
type | bug |
done in | 1.7.1 |
load | 0.250 |
load left | 0.000 |
closed by | #32d191e8504d Remove sys.path manipulation (closes #113034) |
Comments
-
2013/01/09 00:36, written by anon
-
2013/01/16 11:51, written by anon
add commentThe current code now does not work out of the box as cloned repo anymore.
To fix both issues, sys.path manipulations can be used only when the regular import fails (try-except).
After this change was introduced, the README instructions how to use it as a mercurial extension are not valid any more and results in:
*** failed to import extension hgview from /home/wujek/mercurial/ext/hgview/hgext/hgview.py: No module named hgviewlib
hg: unknown command 'qv'
One has to set PYTHONPATH to include hgviewlib module oneself. I would consider it a step back actually, it used to work out of the box.