hgview #10132458 curses ui broken with Mercurial 3.8 or later [resolved]
curses support fails like
File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 355, in calculate_visible
when using Mercurial 3.8 or later that include https://www.mercurial-scm.org/repo/hg/rev/0d6137891114 .
Seen with 1.10.5 | |
priority | important |
---|---|
type | bug |
done in | <not specified> |
load left | 0.000 |
closed by | #7b2f6416809c Make the curses UI work with Mercurial > 3.8 (closes #10132458) |
Comments
-
2019/06/26 12:06, written by ppepiot
-
2019/08/09 22:44, written by mkiilerich
-
2019/08/12 12:49, written by ppepiot
add commentThanks for reporting,
I'm affraid I don't known this part of the code and it's looks non trivial to fix.
IIUC we need to either rather use mercurial.graphmod.ascii instead of our "hgview_ascii" or provide the new "echars" param to _getnodelineedgestail() but I don't understand how this is supposed to work.
Feel free to submit patches, I can review and release them.
Thanks!
Fix proposed on https://bitbucket.org/logilab/hgview/pull-requests/5/fix-curses-ui/diff
Many thanks!
I applied these patches and released in 1.10.7 on pypi
https://hg.logilab.org/master/hgview/rev/9e8d211323e4
https://hg.logilab.org/master/hgview/rev/7b2f6416809c
Tested with python setup.py build && PYTHONPATH=. ./bin/hgview -I curses on mercurial 5.1