hgview #10132458 curses ui broken with Mercurial 3.8 or later [resolved]

curses support fails like

File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 355, in calculate_visible
focus_widget, focus_pos = self._body.get_focus()
File "/home/mk/hgview/hgviewlib/curses/graphlog.py", line 229, in get_focus
return self.data(self._focus)
File "/home/mk/hgview/hgviewlib/curses/graphlog.py", line 127, in data
widget = self.get_widget(pos)
File "/home/mk/hgview/hgviewlib/curses/graphlog.py", line 146, in get_widget
for graph, fields in zzip(self.graphlog(gnode, ctx), self._allfields):
File "/home/mk/hgview/hgviewlib/curses/graphlog.py", line 327, in hgview_ascii
state[0], fix_nodeline_tail))
TypeError: _getnodelineedgestail() takes exactly 7 arguments (6 given)

when using Mercurial 3.8 or later that include https://www.mercurial-scm.org/repo/hg/rev/0d6137891114 .

Seen with 1.10.5

priorityimportant
typebug
done in<not specified>
load left0.000
closed by#7b2f6416809c Make the curses UI work with Mercurial > 3.8 (closes #10132458)

Workflow history

from state (3)to statecommentdateUser
validation pendingresolved2019/08/12 12:49 UTCppepiot
donevalidation pending2019/08/12 12:49 UTCppepiot
opendone2019/08/12 12:42 UTC 

Comments

  • 2019/06/26 12:06, written by ppepiot

    Thanks for reporting,

    I'm affraid I don't known this part of the code and it's looks non trivial to fix.
    IIUC we need to either rather use mercurial.graphmod.ascii instead of our "hgview_ascii" or provide the new "echars" param to _getnodelineedgestail() but I don't understand how this is supposed to work.

    Feel free to submit patches, I can review and release them.

    Thanks!

  • 2019/08/09 22:44, written by mkiilerich

    Fix proposed on https://bitbucket.org/logilab/hgview/pull-requests/5/fix-curses-ui/diff

  • 2019/08/12 12:49, written by ppepiot

    Many thanks!

    I applied these patches and released in 1.10.7 on pypi

    https://hg.logilab.org/master/hgview/rev/9e8d211323e4
    https://hg.logilab.org/master/hgview/rev/7b2f6416809c

    Tested with python setup.py build && PYTHONPATH=. ./bin/hgview -I curses on mercurial 5.1

add comment

Ticket #10132458 - latest update on 2019/08/12, created on 2019/06/08 by Mads Kiilerich